Skip to content

Emit "no-frame-pointer-elim" attribute for closures, shims, and glue.#33909

Merged
bors merged 1 commit into
rust-lang:masterfrom
michaelwoerister:frame-pointer-fix
May 30, 2016
Merged

Emit "no-frame-pointer-elim" attribute for closures, shims, and glue.#33909
bors merged 1 commit into
rust-lang:masterfrom
michaelwoerister:frame-pointer-fix

Conversation

@michaelwoerister

Copy link
Copy Markdown
Member

This will hopefully let perf give better backtraces.
r? @nikomatsakis

@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented May 27, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 4f7ab0e has been approved by nikomatsakis

@bors

bors commented May 29, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4f7ab0e with merge d76c358...

@bors

bors commented May 29, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-opt-rustbuild

@eddyb

eddyb commented May 29, 2016

Copy link
Copy Markdown
Contributor

@bors retry

@bors

bors commented May 30, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4f7ab0e with merge 9f8e3b1...

@bors

bors commented May 30, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@michaelwoerister

Copy link
Copy Markdown
Member Author

@bors retry

@bors

bors commented May 30, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4f7ab0e with merge b522b25...

bors added a commit that referenced this pull request May 30, 2016
…akis

Emit "no-frame-pointer-elim" attribute for closures, shims, and glue.

This will hopefully let `perf` give better backtraces.
r? @nikomatsakis
@bors

bors commented May 30, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@arielb1

arielb1 commented May 30, 2016

Copy link
Copy Markdown
Contributor
---- sync::atomic::AtomicU16::swap_0 stdout ----
    error: could not exec the linker `gcc`: The filename or extension is too long. (os error 206)

This looks spurious

@bors retry

@arielb1

arielb1 commented May 30, 2016

Copy link
Copy Markdown
Contributor

cc @alexcrichton

@bors bors merged commit 4f7ab0e into rust-lang:master May 30, 2016
@alexcrichton

Copy link
Copy Markdown
Member

Ah that retry was #33844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants